[syslog-ng] [Bug 126] [systemd] Add installation of systemd unit file via build-sys

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=126





--- Comment #4 from Balazs Scheidler <bazsi at balabit.hu>  2011-06-26 16:48:19 ---
(In reply to comment #3)
> Created an attachment (id=38)
 --> (https://bugzilla.balabit.com/attachment.cgi?id=38) [details]
> Add --with-systemdsystemunitdir build option
> 
> Oops, I did forget to attach. I agree, the option name sucks, but it seems to have been standardized. The patch uses pkg-config to pull in a default path, but
> there's surely a use case for building syslog-ng without systemd present so the override is necessary.

hmm... I was wondering what the proper default for this option would be. Certainly for packages unit files would need to go to /lib/systemd/system,
but when the admin is compiling his own package, the proper place would rather be /etc/systemd/system, ain't that right?

Do packages specify this option explicitly on the configure command line, or should configure prefer the package location over the user location?

> 
> I guess in the case of the ExecReload it does seem slightly different from Lighttpd because the same process continues. That said, systemd upstream had the
> same response to the ExecReload in rsyslog (which has similar behavior to syslog-ng on HUP) and asked for it to be removed, which it subsequently was.
> 

syslog-ng 3.4 does have an option to initiate reload with a unix domain socket, but that 
still isn't synchronous (yet). 

How should a user initiate HUP based reloads using systemd then?

I understand that this is not a perfect solution, but was good enough for quite some time. 
I wouldn't want to add synchronous reloads to syslog-ng 3.2 (which is not where 
development happens), though it might be viable for 3.4

So for the interim I'd leave ExecReload and change it to the alternative when we get there.

What do you think?


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.