[syslog-ng] linking changes

[Corinna Vinschen]

On Feb 24 10:22, Balazs Scheidler wrote:
> On Wed, 2011-02-23 at 17:35 +0100, Corinna Vinschen wrote:
> > On Feb 23 17:29, Corinna Vinschen wrote:
> > > On Feb 23 16:09, Balazs Scheidler wrote:
> > > > -libdbparser_la_LIBADD = ../../lib/libsyslog-ng.la libsyslog-ng-patterndb.a
> > > > +libdbparser_la_LIBADD = ../../lib/libsyslog-ng.la
> > > 
> > > This fails to build on Cygwin because libdbparser_la_LIBADD is missing a
> > > @OPENSSL_LIBS@ (needed by patternize.c).
> > 
> > Erm... btw., is it really necessary to link against OpenSSL, just to get
> > the RAND_bytes function?  What about testing for /dev/random and using
> > that instead?  That wouldn't introduce any external dependencies.
> 
> Well, yes. But /dev/random is not available on all platforms that
> syslog-ng uses (Solaris 8 for example), and libssl nicely wraps that
> away, not to mention that it supports EGD (entropy gathering daemon) and
> hand-crafted PRNG seeding via the RANDFILE environment variable.
> 
> I simply had no time for properly writing/validating an alternative
> solution and syslog-ng depends on openssl in most cases anyway. (if TLS
> support is enabled).
> 
> But IIRC patternize.c will compile without openssl installed
> (OPENSSL_LIBS will be empty), in that case the UUIDs generated will not
> be guaranteed to be unique.

You're right.  Other parts of syslog-ng will use OpenSSL anyway, so
there's no good reason to avoid it's usage if it's available.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat