[syslog-ng] syslog-ng -s errors with catchall flag (1.6 to 3.1)

[Balazs Scheidler]

Hi,

Thanks for your contribution, I've pushed this patch to the 3.2 version
that fixes the issue. (which is basically the same as you suggested):

commit da3c99f6d77b87edaa9bbc83814123a6f8895644
Author: Balazs Scheidler <bazsi at balabit.hu>
Date:   Fri Apr 8 00:32:35 2011 +0200

    Recognize both "catch-all" and "catchall" because of a documentation bug
    
    The documentation referred to "catchall" whereas syslog-ng expected
    "catch-all".  Now accept both.
    
    Reported-By: Mishou Michael <Michael.Mishou at csirc.irs.gov>
    Signed-off-by: Balazs Scheidler <bazsi at balabit.hu>



On Tue, 2011-04-05 at 17:21 -0400, Mishou Michael wrote:
> Bug 118 submitted, thanks for verifying!
> 
> --Mike
> 
> -----Original Message-----
> From: syslog-ng-bounces at lists.balabit.hu
> [mailto:syslog-ng-bounces at lists.balabit.hu] On Behalf Of Gergely Nagy
> Sent: Tuesday, April 05, 2011 11:17 AM
> To: Syslog-ng users' and developers' mailing list
> Subject: Re: [syslog-ng] syslog-ng -s errors with catchall flag (1.6 to
> 3.1)
> 
> "Mishou Michael" <Michael.Mishou at csirc.irs.gov> writes:
> 
> > Ok, revisiting this today I found the problem after looking at the
> > source code in this snapshot (which my pre-compiled packages were
> based
> > on):
> >
> >
> http://git.balabit.hu/?p=bazsi/syslog-ng-3.1.git;a=snapshot;h=8bf13c304b
> > 6ab5fc1a372b49d55c78370efe14ca
> >
> > All the documentation refers to log path flags: catchall, fallback,
> > final, flow-control.
> >
> > But in center.c the actual strcmp functions are looking for:
> catch-all,
> > fallback, final, flow_control OR flow-control
> 
> It's the same in 3.2 and 3.3 too - good catch!
> 
> Whether this is a documentation or code bug, if the docs say it's
> 'catchall' ever since 2.0, then the code should support that too, along
> with 'catch-all'.
> 
> I'd say this is a bug in both: the documentation should be updated to
> say 'catch-all', which has been working in past versions, and the code
> should be updated to support what the documentation has been advertising
> in the past years.
> 
> We have a public bugzilla at <http://bugzilla.balabit.com/> - you can
> open a ticket there - and it would be great if you would.
> 

-- 
Bazsi