[syslog-ng] [Bug 101] New: Typo in modules/afsocket/Makefile.am

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=101

           Summary: Typo in modules/afsocket/Makefile.am
           Product: syslog-ng
           Version: 3.2.x
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: unspecified
         Component: syslog-ng
        AssignedTo: bazsi at balabit.hu
        ReportedBy: vinschen at redhat.com
Type of the Report: ---
   Estimated Hours: 0.0


Created an attachment (id=27)
 --> (https://bugzilla.balabit.com/attachment.cgi?id=27)
Patch to fix issue "Typo in modules/afsocket/Makefile.am"

Usually $DESTDIR is used without a trailing slash, for instance:

  $(DESTDIR)$(prefix)

In modules/afsocket/Makefile.am, it's erroneously used with a trailing slash in the rules creating the libafsocket.so symlink:

  $(DESTDIR)/$(moduledir)

Assuming $(DESTDIR) is empty, this may result in an erroneous double slash at the beginning of the resulting path:

  moduledir=/usr/lib/syslog-ng  ==>  $(DESTDIR)/$(moduledir) == //usr/lib/syslog-ng

Per POSIX, a double slash at the start of the path is allowed to have a system-dependent meaning, so this shouldn't happen.

I've attached a patch to fix this issue.


Corinna


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.