[syslog-ng] [PATCH] typo in misc.c, function resolve_user?
Balazs Scheidler
bazsi at balabit.hu
Wed Apr 1 15:31:43 CEST 2009
This has already been fixed in recent git.
On Wed, 2009-04-01 at 15:21 +0200, Corinna Vinschen wrote:
> Ping?
>
> On Mar 25 17:18, Corinna Vinschen wrote:
> > Hi,
> >
> > a Cygwin user got a message in the syslog every time the syslog-ng
> > service started up:
> >
> > Error resolving user; user='system'
> >
> > He also found why this message was generated. The function resolve_user()
> > in misc.c appears to have a typo. If the incoming user argument points
> > to a non-empty string, resolve_user() just returns NULL. So, the following
> > getpwnam is only called for an empty user string. This looks like a typo.
> >
> > One possible fix below. However, maybe the intention was actually to
> > test for
> >
> > if (!user)
> >
> > instead of
> >
> > if (!*user)
> >
--
Bazsi
More information about the syslog-ng
mailing list