[syslog-ng] Error parsing conf file?

[Balazs Scheidler]

Hi,

> -----Original Message-----
> From: syslog-ng-bounces at lists.balabit.hu [mailto:syslog-ng-bounces at lists.balabit.hu] On Behalf Of Balazs Scheidler
> Sent: Tuesday, July 05, 2005 6:47 AM
> To: Syslog-ng users' and developers' mailing list
> Subject: RE: [syslog-ng] Error parsing conf file?
> 
> 
> On Mon, 2005-07-04 at 15:56 -0600, Zb Indelak wrote:
> > Any progress / clues on the multiple file-open bug?  I'm using a 
> > multi-processor (2 CPUs) system, if that perhaps makes a difference.  
> > With the 20050704 snapshot I've seen a single file open over 20 times 
> > each.
> 
> not yet, sorry, I was hunting down a bug for a customer, so did not have too much time lately. But I'm trying to look into this RSN.
> 
> ps: I hate bugs that screw up the heap structure :(
> 

I have now fixed this issue with the following patch:

--- orig/src/logwriter.c
+++ mod/src/logwriter.c
@@ -327,7 +327,11 @@ log_writer_deinit(LogPipe *s, GlobalConf
   LogWriter *self = (LogWriter *) s;

   if (self->source)
-    g_source_destroy(self->source);
+    {
+      g_source_destroy(self->source);
+      g_source_unref(self->source);
+      self->source = NULL;
+    }
   return TRUE;
 }

It will be included in tomorrow's snapshot.

-- 
Bazsi