[syslog-ng]Re: leak in spoof_source support

Balazs Scheidler syslog-ng@lists.balabit.hu
Fri, 06 Aug 2004 20:17:13 +0200


On Fri, 2004-08-06 at 20:11, Balazs Scheidler wrote:
> >Researching the problem we found out that it seems to be related to
> >the 
> >"address spoofing" options. Enabling this option, under heavy traffic (which 
> >means always, in our case) we experience this memory leak problem.
> >Disabling the address spoofing option, everything runs smoothly with only 
> >about 720k memory occupation.
> >
> >The problem is "we need this option"... And this is getting critical, can 
> >anyone hep?
> >Thanks,
> 
> Hmm.. I possible forgot to free something in that path. I'll check it out 
> for you.

Can you check if this one works for you?

Index: src/afinet.c
===================================================================
RCS file: /var/cvs/syslog-ng/syslog-ng/src/afinet.c,v
retrieving revision 1.25.4.6
diff -u -r1.25.4.6 afinet.c
--- src/afinet.c        5 Aug 2004 11:35:12 -0000       1.25.4.6
+++ src/afinet.c        6 Aug 2004 18:15:32 -0000
@@ -653,6 +653,7 @@
                        if (libnet_write(self->lnet_ctx) < 0) {
                                werror("Error sending raw frame, error: %z", libnet_geterror(self->lnet_ctx));
                        }
+                       ol_string_free(msg_line);
                }
                else {
                fallback_socket:



-- 
Bazsi
PGP info: KeyID 9AF8D0A9 Fingerprint CD27 CFB0 802C 0944 9CFD 804E C82C 8EB1