[syslog-ng]performance test questions

Balazs Scheidler bazsi@balabit.hu
Fri, 31 Jan 2003 10:19:21 +0100


On Thu, Jan 30, 2003 at 07:09:57PM +0100, Roberto Nibali wrote:
> >reports the number of dropped messages in a separate message sent once 
> >every
> >ten minutes (default).
> 
> Call me stupid but (assuming you mean the STATS part):
> 
> ratz@zar:~/down/log > find . -name "*.[ch]" -exec grep -n dropped_pkts 
> /dev/null {} \;
> ./libol-0.3.8/src/pkt_buffer.h:30:int pktbuf_dropped_pkts;
> ./syslog-ng-1.5.25/src/main.c:138:	notice("STATS: dropped %i\n", 
> pktbuf_dropped_pkts);
> ./syslog-ng-1.5.25/src/main.c:139:	pktbuf_dropped_pkts = 0;
> ratz@zar:~/down/log >
> 
> What else then 0 should this code print? At least I've found the hardcoded 
> timeout in libol/src/io.c. :)

hmm.. the code to increment that variable _was_ present. ... checked my CVS
tree, it was removed between 1.11 and 1.12 revisions of pkt_buffer.c.

PACKET_STATS was implemented in 26th August, 2001, but the code to increment
the dropped counter was removed in 11th October, 2001. My ChangeLog shows
that this was the time when libol was branched to 0.3 and 0.2 branches. I
must have made a mistake.

I even received reports in the mailing list which shows the STATS message
with drops > 0. I've found this mail dated "Date: Fri, 2 Nov 2001 10:00:58
+0100" So the feature must have been there at that time.

I wonder how could that happen. ;(

-- 
Bazsi
PGP info: KeyID 9AF8D0A9 Fingerprint CD27 CFB0 802C 0944 9CFD 804E C82C 8EB1