[syslog-ng]syslog-ng 1.5.25 released

[Roberto Nibali]

Hello,

>         * The previous kernel bug workaround in libol fixed the issue for
>           the 2.4.20rc? kernels only, the current workaround should also
>           work for 2.4.20 final as well.

In the Changelog I read that you've fixed a bug in libol causing garbled output 
lines when a target buffer is full. I presume we're talking about this fix:

@@ -132,7 +132,7 @@
  				if (self->super.writable)
  					(*self->super.writable) = 1;
  			}
-			else if (res != 0) {
+			else {
  				/* this is slow, because of another memory move
  				 * but this is run rarely anyway */
  				struct buffer_node *item;

Would you care to explain to me this fix, please? As I read it, it only kicks in 
in case write(2) returns with a 0. But this 0 doesn't mean 0 bytes have been 
written, but something else. I'm a bit confused. Keep in mind that I haven't 
read your code all too well yet ;).

Since a few releases of syslog-ng I've missed the klogctl tool. As I wasn't 
subscribed to this list before 2003 I might have missed its removal announce. A 
quick search reveiled that it was dropped in favour of dmesg(8). There are still 
quite some references in various places in the source. You might want to remove 
them:

ratz@zar:~/down/log/syslog-ng-1.5.25 > grep -r klogctl *
ChangeLog:	* utils/klogctl.c: New file to control kernel log level
Makefile:klogctl = klogctl
Makefile.in:klogctl = @klogctl@
NEWS:	* Added klogctl program to control kernel logging level on Linux
config.log:configure:1854: checking whether to compile klogctl
config.status:s%@klogctl@%klogctl%g
configure:echo $ac_n "checking whether to compile klogctl""... $ac_c" 1>&6
configure:echo "configure:1854: checking whether to compile klogctl" >&5
configure:	klogctl=klogctl
configure:	klogctl=""
configure:s%@klogctl@%$klogctl%g
configure.in:AC_MSG_CHECKING(whether to compile klogctl)
configure.in:	klogctl=klogctl
configure.in:	klogctl=""
configure.in:AC_SUBST(klogctl)
contrib/Makefile.in:klogctl = @klogctl@
contrib/Makefile:klogctl = klogctl
doc/sgml/Makefile.in:klogctl = @klogctl@
doc/sgml/Makefile:klogctl = klogctl
doc/Makefile.in:klogctl = @klogctl@
doc/Makefile:klogctl = klogctl
src/tests/Makefile.in:klogctl = @klogctl@
src/tests/Makefile:klogctl = klogctl
src/Makefile.in:klogctl = @klogctl@
src/Makefile:klogctl = klogctl
ratz@zar:~/down/log/syslog-ng-1.5.25 >

Best regards,
Roberto Nibali, ratz
-- 
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc