[ramirose@gmail.com: [PATCH net-2.6] ipv4: remove unused field in struct flowi (include/net/flow.h).]
Bah, This got applied by DaveM. Unfortunately we use this field so we'll have to add this back in. ----- Forwarded message from Rami Rosen <ramirose@gmail.com> ----- From: Rami Rosen <ramirose@gmail.com> Subject: [PATCH net-2.6] ipv4: remove unused field in struct flowi (include/net/flow.h). Date: Tue, 05 Aug 2008 11:14:02 +0300 To: davem@davemloft.net, netdev@vger.kernel.org Hi, This patch removes an unused field (flags) from struct flowi; it seems that this "flags" field was used once in the past for multipath routing with FLOWI_FLAG_MULTIPATHOLDROUTE flag (which does no longer exist); however, the "flags" field of struct flowi is not used anymore. Regards, Rami Rosen Signed-off-by: Rami Rosen <ramirose@gmail.com> diff --git a/include/net/flow.h b/include/net/flow.h index ad16e00..228b247 100644 --- a/include/net/flow.h +++ b/include/net/flow.h @@ -47,7 +47,6 @@ struct flowi { #define fl4_scope nl_u.ip4_u.scope __u8 proto; - __u8 flags; union { struct { __be16 sport; ----- End forwarded message ----- -- KOVACS Krisztian
On Tue, 2008-08-05 at 11:42 +0200, KOVACS Krisztian wrote:
Bah,
This got applied by DaveM. Unfortunately we use this field so we'll have to add this back in.
At last netfilter workshop, DaveM said that he is ok with adding flags to struct flowi, thus I _think_ he will still be ok with it to readd this field. -- Bazsi
Hi, On k, aug 05, 2008 at 11:58:17 +0200, Balazs Scheidler wrote:
On Tue, 2008-08-05 at 11:42 +0200, KOVACS Krisztian wrote:
Bah,
This got applied by DaveM. Unfortunately we use this field so we'll have to add this back in.
At last netfilter workshop, DaveM said that he is ok with adding flags to struct flowi, thus I _think_ he will still be ok with it to readd this field.
Yes, I think it's not a big deal as the hole is still there in the structure layout. -- KOVACS Krisztian
participants (2)
-
Balazs Scheidler
-
KOVACS Krisztian