<div style="font-family: 'Calibri', 'sans-serif';"><div dir="ltr">
<div dir="ltr"><br></div><div dir="ltr"><br></div><div dir="ltr"><div dir="ltr">Sent from my HTC</div></div>
</div><br><div id="htc_header">----- Reply message -----<br>From: "Vincent Bernat" <bernat@luffy.cx><br>To: "Laszlo Budai" <laszlo.budai@outlook.com><br>Cc: "Syslog-ng users' and developers' mailing list" <syslog-ng@lists.balabit.hu>, "Vithulan MV" <vithulanmv.12@cse.mrt.ac.lk><br>Subject: [syslog-ng] Finding feature owner for Kafka source project<br>Date: Sat, May 21, 2016 23:58</div></div><br><div dir="ltr"><pre style="word-wrap: break-word; white-space: pre-wrap;"> ❦ 21 mai 2016 11:58 -0700, Laszlo Budai <laszlo.budai@outlook.com> :
> As you mentioned we have Kafka destination driver written in C in
> syslog-ng incubator, so users can use it. It should not be a problem
> if a feature is available only in the syslog-ng incubator.
Well, it is because most users will never use it.</pre><pre style="word-wrap: break-word; white-space: pre-wrap;"><br></pre><pre style="word-wrap: break-word; white-space: pre-wrap;">I don't know why... maybe we should make it clear what is incubator.</pre><pre style="word-wrap: break-word; white-space: pre-wrap;">For me it contains two kind of features:</pre><pre style="word-wrap: break-word; white-space: pre-wrap;">1) experimental features that are not really tested, and maybe the code would also neee some polishment before merge into syslog-ng master</pre><pre style="word-wrap: break-word; white-space: pre-wrap;">2) well implemented features that are using some unstable dependencies</pre><pre style="word-wrap: break-word; white-space: pre-wrap;">> As the Kafka C client is stable enough, I don't see any problems in
> integrating it to the syslog-ng master (just someone should create a
> pull request).
Good to know. That's not what you told me in August. I will fix the
performance limitations and do a PR for master.</pre><pre style="word-wrap: break-word; white-space: pre-wrap;">I said that my plan is to keep the C kafka dst in incubator. Last year ;)</pre><pre style="word-wrap: break-word; white-space: pre-wrap;">But Kafka C lib seems to be a stable lib during the last 8-9 months which makes it possible to move forward from incubator. </pre><pre style="word-wrap: break-word; white-space: pre-wrap;"><br></pre><pre style="word-wrap: break-word; white-space: pre-wrap;">L.</pre><pre style="word-wrap: break-word; white-space: pre-wrap;">--
Make it right before you make it faster.
- The Elements of Programming Style (Kernighan & Plauger)
</pre></div>