<div dir="ltr"><div><div><div>Hi,<br><br></div>Let me try to describe what is needed to parse options from the configuration file:<br><ul><li>curl-grammar.ym: is a yacc/bison source file that parses the curl specific portion of the configuration. It is able to generate parsers for LALR(1) languages.</li><li>curl-parser.c: contains the set of keywords that curl understands. This maps keywords found in the configuration into tokens that the grammar is able to process. A token is basically a numeric identifier.</li></ul><p>So for instance to add a "header" option, you will need this stuff:<br></p><p>1) define a token in the grammar, so it becomes available as a macro</p><p><span style="font-family:monospace,monospace">diff --git a/modules/curl/curl-grammar.ym b/modules/curl/curl-grammar.ym<br>index c3aaf00..eab317c 100644<br>--- a/modules/curl/curl-grammar.ym<br>+++ b/modules/curl/curl-grammar.ym<br>@@ -47,6 +47,7 @@<br> %parse-param {gpointer arg}<br> <br> %token KW_CURL<br>+%token KW_HEADER<br> <br> %type <ptr> driver<br> %type <ptr> curl_destination<br></span></p><p><br></p><p>If you recompile the curl module, this will make KW_HEADER to become available in curl-grammar.h<br></p><p>2) add a keyword to curl-parser.c</p><p>This will tell the syslog-ng lexer (a component that reads the configuration file and breaks them into tokens) to map the string "header" into a symbolic token named KW_HEADER.</p><p><span style="font-family:monospace,monospace">diff --git a/modules/curl/curl-parser.c b/modules/curl/curl-parser.c<br>index 6958a8d..b60ef0b 100644<br>--- a/modules/curl/curl-parser.c<br>+++ b/modules/curl/curl-parser.c<br>@@ -30,6 +30,7 @@ int curl_parse(CfgLexer *lexer, LogDriver **instance, gpointer arg);<br> <br> static CfgLexerKeyword curl_keywords[] = {<br> { "curl", KW_CURL },<br>+ { "header", KW_HEADER },<br> { NULL }<br> };</span><br> <br></p><p>3) add rules to the grammar to parse this option<br></p><p>First we need a small refactor in the curl-grammar file to save the just instantiated CurlDestinationDriver (I hand edited this hunk for clarity, so it will not apply automatically):</p><p><span style="font-family:monospace,monospace"><br>@@ -71,7 +72,15 @@ driver<br> ;<br> <br> curl_destination<br>- : KW_CURL '(' ')' { $$ = curl_dd_new(configuration); }<br>+ : KW_CURL <br>+ {<br>+ last_driver = curl_dd_new(configuration);<br>+ }<br>+ '(' ')' { $$ = last_driver; }<br>+ ;<br><br></span><br></p><p>This basically just stores the driver instance in a variable named "last_driver" (defined by the core cfg-grammar.y file). So we can later use this to call setters on.</p><p>And now let's add option parsing (this time the entire hunk):<span style="font-family:monospace,monospace"><br></span></p><p><span style="font-family:monospace,monospace">@@ -71,7 +72,20 @@ driver<br> ;<br> <br> curl_destination<br>- : KW_CURL '(' ')' { $$ = curl_dd_new(configuration); }<br>+ : KW_CURL <br>+ {<br>+ last_driver = curl_dd_new(configuration);<br>+ }<br>+ '(' curl_options ')' { $$ = last_driver; }<br>+ ;<br>+<br>+curl_options<br>+ : curl_option curl_options<br>+ |<br>+ ;<br>+<br>+curl_option<br>+ : KW_HEADER '(' string string ')' { curl_dd_set_header(last_driver, $3, $4); }<br> ;<br> <br> /* INCLUDE_RULES */<br></span><br></p><p>What this does is that we added a rule "curl_options" within the parentheses of our original "curl" rule, which is the rule that must match the configuration as we parse it. (think of it as a recursive tree).</p><p>curl_options is satisfied with either an empty rule (e.g. no options) or recursing itself with a curl_option rule. Note the plural and singular names, curl_options is responsible to match a list of "curl_option"s.</p><p>curl_option is responsible for parsing individual options, for now only a single rule is there, KW_HEADER, which when parsed will call curl_dd_set_header().</p><p>You can add further options like this:</p><span style="font-family:monospace,monospace">+curl_option<br>+ : KW_HEADER '(' string string ')' { curl_dd_set_header(last_driver, $3, $4); }<br></span></div><span style="font-family:monospace,monospace">+ | KW_URL '(' string ')' { curl_dd_set_url(last_driver, $3); }<br><br></span></div><br><p>Variables like $1, $2 and so on represent the Nth token in the rule, e.g. $3 in the KW_HEADER branch is the first string value. $4, is the 2nd.</p><p>Hope this helps. You will definitely be able to find tutorials that describe both yacc/lex, however there are a number of quirks how syslog-ng applies them, primarily to make it possible to extend the base grammar with plugins.</p><p>Cheers,</p><p>Bazsi<br></p><span style="font-family:monospace,monospace"></span><div><span style="font-family:monospace,monospace"><br></span><div><div><span style="font-family:monospace,monospace"> </span></div></div></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr">-- <br>Bazsi<br></div></div></div>
<br><div class="gmail_quote">On Mon, Feb 1, 2016 at 10:01 PM, Marc Falzon <span dir="ltr"><<a href="mailto:m@baha.mu" target="_blank">m@baha.mu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Bazsi<br>
<br>
Sorry to bother you again, but now that I'm done prototyping the "curl" part of my module using hardcoded values for testing I'm now facing the "grammar/parser" problem: could you please drive me though the basics of how this works? I tried to understand looking at other modules but I don't understand at all.<br>
<br>
Basically, I'd like to be able to specify some configuration settings in the syslog-ng configuration, such as url, some HTTP headers... It would look like this:<br>
<br>
destination d_curl {<br>
curl(url("<a href="http://logs.example.net:5140/" rel="noreferrer" target="_blank">http://logs.example.net:5140/</a>" header("Content-Type: application/json") header("X-Custom-Header: blah")));<br>
};<br>
<br>
<br>
My code is still available at <a href="https://github.com/falzm/syslog-ng/tree/f/curl-module/modules/curl" rel="noreferrer" target="_blank">https://github.com/falzm/syslog-ng/tree/f/curl-module/modules/curl</a><br>
<br>
Thank you in advance,<br>
<br>
m.<br>
<span class=""><br>
<br>
On Saturday 30 January 2016 at 10:17, <a href="mailto:m@baha.mu">m@baha.mu</a> wrote:<br>
<br>
> Hi<br>
><br>
> Great! I should be able to get going from here, thank you for your help.<br>
><br>
> Cheers,<br>
><br>
> m.<br>
><br>
</span><span class="">> > On Jan 30, 2016, at 08:56, Scheidler, Balázs <<a href="mailto:balazs.scheidler@balabit.com">balazs.scheidler@balabit.com</a> (mailto:<a href="mailto:balazs.scheidler@balabit.com">balazs.scheidler@balabit.com</a>)> wrote:<br>
> ><br>
> > Hi,<br>
> ><br>
> > I have added code to your module, it compiles and is able to accept messages to be sent, and prints a debug message whenever that happens.<br>
> ><br>
> > I didn't have too much time to clean it up, but I hope this helps to start the ball rolling.<br>
> ><br>
> > <a href="https://github.com/balabit/syslog-ng/compare/f/curl-module" rel="noreferrer" target="_blank">https://github.com/balabit/syslog-ng/compare/f/curl-module</a> <<a href="https://github.com/balabit/syslog-ng/compare/f/curl-module" rel="noreferrer" target="_blank">https://github.com/balabit/syslog-ng/compare/f/curl-module</a>><br>
> ><br>
> ><br>
> > Bazsi<br>
> ><br>
> > --<br>
> > Bazsi<br>
> ><br>
> > On Sat, Jan 23, 2016 at 9:27 PM, <<a href="mailto:m@baha.mu">m@baha.mu</a> <mailto:<a href="mailto:m@baha.mu">m@baha.mu</a>>> wrote:<br>
> ><br>
> > > On Jan 23, 2016, at 21:23, Scheidler, Balázs <<a href="mailto:balazs.scheidler@balabit.com">balazs.scheidler@balabit.com</a> <mailto:<a href="mailto:balazs.scheidler@balabit.com">balazs.scheidler@balabit.com</a>>> wrote:<br>
> > ><br>
> > > If you commit your code to a branch I can help with the basic skeleton of the parser/grammar<br>
> ><br>
> ><br>
> > Thank you Balázs, my code is available here: <a href="https://github.com/falzm/syslog-ng/tree/f/curl-module/modules/curl" rel="noreferrer" target="_blank">https://github.com/falzm/syslog-ng/tree/f/curl-module/modules/curl</a> <<a href="https://github.com/falzm/syslog-ng/tree/f/curl-module/modules/curl" rel="noreferrer" target="_blank">https://github.com/falzm/syslog-ng/tree/f/curl-module/modules/curl</a>><br>
> ><br>
> > m.<br>
> ><br>
> ><br>
> > ><br>
> > > On Jan 23, 2016 5:54 PM, "Marc Falzon" <<a href="mailto:m@baha.mu">m@baha.mu</a> <mailto:<a href="mailto:m@baha.mu">m@baha.mu</a>>> wrote:<br>
</span>> > > I successfully generated a module template using the `create_plugin.sh (<a href="http://create_plugin.sh" rel="noreferrer" target="_blank">http://create_plugin.sh</a>)` script, however I don't have the slightest idea on how to get started from here (I mean for the 'plugin glue', I can manage the cURL part)... The most problematic step for me is the whole parser/grammar thing, to which I believe to involve YACC/Bison parsing but I don't know how it works and it's too big of a learning curve for what I want to achieve at this point... Since the Gitbook doesn't provide any useful information on module development at the moment, is there any way to get me started on this topic? I'm not a developer (sysadmin), and trying to learn from existing module doesn't quite cut it.<br>
<div class="HOEnZb"><div class="h5">> > ><br>
> > > Thank you,<br>
> > ><br>
> > > m.<br>
> > ><br>
> > ><br>
> > > On Friday 22 January 2016 at 11:35, Tibor Benke wrote:<br>
> > ><br>
> > > > There is also a shell script which generates a basic destination skeleton. You can find its source on this brach: <a href="https://github.com/juhaszviktor/syslog-ng/tree/f/plugin-creator" rel="noreferrer" target="_blank">https://github.com/juhaszviktor/syslog-ng/tree/f/plugin-creator</a> <<a href="https://github.com/juhaszviktor/syslog-ng/tree/f/plugin-creator" rel="noreferrer" target="_blank">https://github.com/juhaszviktor/syslog-ng/tree/f/plugin-creator</a>> . Check the dev-utils/plugin_skeleton_creator directory and this commit for the usage: <a href="https://github.com/juhaszviktor/syslog-ng/commit/89361d4d1817560ce8c906209355f1b737a28010" rel="noreferrer" target="_blank">https://github.com/juhaszviktor/syslog-ng/commit/89361d4d1817560ce8c906209355f1b737a28010</a> <<a href="https://github.com/juhaszviktor/syslog-ng/commit/89361d4d1817560ce8c906209355f1b737a28010" rel="noreferrer" target="_blank">https://github.com/juhaszviktor/syslog-ng/commit/89361d4d1817560ce8c906209355f1b737a28010</a>><br>
> > > ><br>
> > > > 2016-01-22 11:33 GMT+01:00 Marc Falzon <<a href="mailto:m@baha.mu">m@baha.mu</a> <mailto:<a href="mailto:m@baha.mu">m@baha.mu</a>> (mailto:<a href="mailto:m@baha.mu">m@baha.mu</a> <mailto:<a href="mailto:m@baha.mu">m@baha.mu</a>>)>:<br>
> > > > > Hi Bazsi,<br>
> > > > ><br>
> > > > ><br>
> > > > > On Friday 22 January 2016 at 11:28, Scheidler, Balázs wrote:<br>
> > > > ><br>
> > > > > > not really, but maybe I would read the "official" modules source code instead. and of course you can ask questions on the mailing list. :)<br>
> > > > ><br>
> > > > ><br>
> > > > > Yes that's what I've started to do, but a proper documentation is preferable, saves time and avoid confusion ;)<br>
> > > > ><br>
> > > > > > if you want to create a destination, the easiest is to create a threaded destination, where the output is an independent thread, that can use a synchronous API. Of course this is going to be slower than using an asynchronous implementation, but that usually is good enough,<br>
> > > > ><br>
> > > > > Thank you for the hint. Given my use case (HTTP destination) I think I'm safe to go with an asynchronous implementation since each request is stateless, no connections/locks involved.<br>
> > > > ><br>
> > > > > m.<br>
> > > > ><br>
> > > > > ><br>
> > > > > > On Fri, Jan 22, 2016 at 11:03 AM, Marc Falzon <<a href="mailto:m@baha.mu">m@baha.mu</a> <mailto:<a href="mailto:m@baha.mu">m@baha.mu</a>> (mailto:<a href="mailto:m@baha.mu">m@baha.mu</a> <mailto:<a href="mailto:m@baha.mu">m@baha.mu</a>>) (mailto:<a href="mailto:m@baha.mu">m@baha.mu</a> <mailto:<a href="mailto:m@baha.mu">m@baha.mu</a>>)> wrote:<br>
> > > > > > > Hi<br>
> > > > > > ><br>
> > > > > > > Is there any documentation on how to develop new syslog-ng module using the native C API, besides reading the incubator modules source code?<br>
> > > > > > ><br>
> > > > > > > Cheers,<br>
> > > > > > ><br>
> > > > > > > m.<br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > ______________________________________________________________________________<br>
> > > > > > > Member info: <a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a> <<a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a>><br>
> > > > > > > Documentation: <a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a> <<a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a>><br>
> > > > > > > FAQ: <a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a> <<a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a>><br>
> > > > > ><br>
> > > > > ><br>
> > > > > ><br>
> > > > > ><br>
> > > > > ><br>
> > > > > > ______________________________________________________________________________<br>
> > > > > > Member info: <a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a> <<a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a>><br>
> > > > > > Documentation: <a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a> <<a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a>><br>
> > > > > > FAQ: <a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a> <<a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a>><br>
> > > > ><br>
> > > > ><br>
> > > > ><br>
> > > > ><br>
> > > > ><br>
> > > > ><br>
> > > > > ______________________________________________________________________________<br>
> > > > > Member info: <a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a> <<a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a>><br>
> > > > > Documentation: <a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a> <<a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a>><br>
> > > > > FAQ: <a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a> <<a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a>><br>
> > > ><br>
> > > ><br>
> > > ><br>
> > > ><br>
> > > > ______________________________________________________________________________<br>
> > > > Member info: <a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a> <<a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a>><br>
> > > > Documentation: <a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a> <<a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a>><br>
> > > > FAQ: <a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a> <<a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a>><br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > > ______________________________________________________________________________<br>
> > > Member info: <a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a> <<a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a>><br>
> > > Documentation: <a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a> <<a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a>><br>
> > > FAQ: <a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a> <<a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a>><br>
> > ><br>
> > > ______________________________________________________________________________<br>
> > > Member info: <a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a> <<a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a>><br>
> > > Documentation: <a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a> <<a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a>><br>
> > > FAQ: <a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a> <<a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a>><br>
> ><br>
> ><br>
> ><br>
> > ______________________________________________________________________________<br>
> > Member info: <a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a> <<a href="https://lists.balabit.hu/mailman/listinfo/syslog-ng" rel="noreferrer" target="_blank">https://lists.balabit.hu/mailman/listinfo/syslog-ng</a>><br>
> > Documentation: <a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a> <<a href="http://www.balabit.com/support/documentation/?product=syslog-ng" rel="noreferrer" target="_blank">http://www.balabit.com/support/documentation/?product=syslog-ng</a>><br>
> > FAQ: <a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a> <<a href="http://www.balabit.com/wiki/syslog-ng-faq" rel="noreferrer" target="_blank">http://www.balabit.com/wiki/syslog-ng-faq</a>><br>
><br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div>