[syslog-ng] [PATCH (3.4) 0/3] afsql code cleanups

Balazs Scheidler bazsi at balabit.hu
Tue May 1 14:18:34 CEST 2012


Hi,

I generally like these changes and would apply them too. However I know
about some related work by the BalaBit syslog-ng team, I'm afraid we
would have an enourmous conflict when trying to pull their stuff into
our tree. Since this is an opportunity to larger changes I'd love to
integrate their stuff too.

Can you give it a peek?

PS: the thing I'd love to see is to use the LogQueue backlog instead of
pending_msg in @self.

Thanks.

On Fri, 2012-04-27 at 13:53 +0200, Gergely Nagy wrote:
> The patches following this mail are my attempts at cleaning up the
> afsql driver here and there, mostly afsql_dd_insert_db(), in
> preparation for moving towards LogThreadedDestDriver (which will be
> posted separately a bit later).
> 
> The migration is possible without these patches, but these are worth
> applying even without the LogThreadedDestDriver patches, as these
> present no real architectural change, just a little refactoring.
> 
> I think the code could be cleaned up further, but for the time being,
> I only did what I thought necessary to prepare for migration to
> LogThreadedDestDriver.
> 
> 
> ______________________________________________________________________________
> Member info: https://lists.balabit.hu/mailman/listinfo/syslog-ng
> Documentation: http://www.balabit.com/support/documentation/?product=syslog-ng
> FAQ: http://www.balabit.com/wiki/syslog-ng-faq
> 
> 

-- 
Bazsi




More information about the syslog-ng mailing list