[syslog-ng] [Bug 119] Compiling syslog-ng 3.2.3 with gcc 4.6: warnings

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=119





--- Comment #3 from Jose Oliveira <jpo at di.uminho.pt>  2011-05-04 17:25:21 ---
(In reply to comment #2)
> Thanks for your report. It's nice to see you back Jose :)
> 
> I've committed & pushed a series of patches to 3.2 master that fix most of the warnings. Some that complains about chown/chmod I didn't fix, as:
> 
> 1) there's a related change in newer versions of syslog-ng, and I didn't want to diverge, nor backport that code
> 2) I really don't want to handle these errors, but ignore them silently.
> 
> There was one ugly bug that was revealed by these warnings which is definitely worth fixing. One of the syslog-ng supplied macros used by the generated parser
> file contained a possible out-of-bounds reference, which could've cause crashes when the config file is being parsed and an error is reported against it, as
> the uninitialized pointer would be used in the error path. 
> 
> The rest of the warnings were not real bugs, but better have them fixed.
> 

Balazs,

Thanks for the promptly warning fixes!
A new build from git only produces the following ones (8 of 9 expected):

----------
misc.c:420:18: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
misc.c:422:18: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
afunix.c:149:14: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
afunix.c:151:14: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
affile.c:109:15: warning: ignoring return value of 'fchown', declared with attribute warn_unused_result [-Wunused-result]
affile.c:111:15: warning: ignoring return value of 'fchown', declared with attribute warn_unused_result [-Wunused-result]
syslog-format.c:664:9: warning: variable 'sd_param_len' set but not used [-Wunused-but-set-variable]
patternize.c:85:2: warning: #warning "openssl seems to be missing on your system, UUID generation will be disabled in pdbtool patternize" [-Wcpp]
patternize.c:85:2: warning: #warning "openssl seems to be missing on your system, UUID generation will be disabled in pdbtool patternize" [-Wcpp]
----------

/jpo


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.